class RuboCop::Cop::Rails::HasManyOrHasOneDependent

This cop looks for `has_many` or `has_one` associations that don't specify a `:dependent` option. It doesn't register an offense if `:through` option was specified.

@example

# bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

Constants

MSG

Public Instance Methods

on_send(node) click to toggle source
# File lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb, line 53
def on_send(node)
  return if active_resource?(node.parent)

  unless association_without_options?(node)
    return if valid_options?(association_with_options?(node))
  end

  return if valid_options_in_with_options_block?(node)

  add_offense(node, location: :selector)
end

Private Instance Methods

active_resource?(node) click to toggle source
# File lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb, line 98
def active_resource?(node)
  return false if node.nil?

  active_resource_class?(node)
end
contain_valid_options_in_with_options_block?(node) click to toggle source
# File lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb, line 75
def contain_valid_options_in_with_options_block?(node)
  if with_options_block(node)
    return true if valid_options?(with_options_block(node))

    return false unless node.parent

    return true if contain_valid_options_in_with_options_block?(
      node.parent.parent
    )
  end

  false
end
valid_options?(options) click to toggle source
# File lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb, line 89
def valid_options?(options)
  return true unless options
  return true if options.any? do |o|
    dependent_option?(o) || present_option?(o)
  end

  false
end
valid_options_in_with_options_block?(node) click to toggle source
# File lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb, line 67
def valid_options_in_with_options_block?(node)
  return true unless node.parent

  n = node.parent.begin_type? ? node.parent.parent : node.parent

  contain_valid_options_in_with_options_block?(n)
end