File obs-server-2.10-0113-Ignore-rubocop-offenses-in... of Package obs-server

Overview Repositories Revisions Requests Users Attributes Meta

File obs-server-2.10-0113-Ignore-rubocop-offenses-in-existing-codebase-after-r.patch of Package obs-server (Revision 2264e8d04946bebb1f76fe9fcb3c20e1)

Currently displaying revision 2264e8d04946bebb1f76fe9fcb3c20e1 , Show latest

From 38347edac89dbab4a8d45c6f3928d98dc8fc415f Mon Sep 17 00:00:00 2001
From: Lukas Krause <lkrause@suse.de>
Date: Fri, 3 Apr 2020 16:02:14 +0200
Subject: [PATCH] Ignore rubocop offenses in existing codebase after rails 6
 upgrade

Rubocop complains about two offenses in the configuration_controller
after the upgrade to Rails 6.0
---
 src/api/.rubocop_todo.yml | 63 +++++++++++++++++++++++++++++----------
 1 file changed, 47 insertions(+), 16 deletions(-)

diff --git a/src/api/.rubocop_todo.yml b/src/api/.rubocop_todo.yml
index 0aca96cf73..be47481e12 100644
--- a/src/api/.rubocop_todo.yml
+++ b/src/api/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2019-04-04 07:57:42 +0000 using RuboCop version 0.66.0.
+# `rubocop --auto-gen-config --auto-gen-only-exclude`
+# on 2020-04-03 13:59:29 +0000 using RuboCop version 0.81.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -57,7 +57,7 @@ Layout/EmptyComment:
     - 'app/models/bs_request_action_maintenance_release.rb'
     - 'app/models/bs_request_action_set_bugowner.rb'
 
-# Offense count: 569
+# Offense count: 580
 # Cop supports --auto-correct.
 Layout/EmptyLineAfterGuardClause:
   Enabled: false
@@ -180,7 +180,17 @@ Lint/UnneededCopEnableDirective:
   Exclude:
     - 'test/unit/schema_test.rb'
 
-# Offense count: 37
+# Offense count: 5
+# Configuration parameters: AllowComments.
+Lint/SuppressedException:
+  Exclude:
+    - 'app/helpers/maintenance_helper.rb'
+    - 'app/models/package.rb'
+    - 'app/models/user.rb'
+    - 'lib/obsapi/markdown_renderer.rb'
+    - 'spec/models/project_spec.rb'
+
+# Offense count: 36
 Lint/UriEscapeUnescape:
   Exclude:
     - 'app/controllers/group_controller.rb'
@@ -199,7 +209,8 @@ Lint/UriEscapeUnescape:
     - 'spec/models/package_spec.rb'
     - 'test/functional/request_controller_test.rb'
 
-# Offense count: 903
+# Offense count: 885
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 236
 
@@ -228,7 +239,8 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   Max: 1105
 
-# Offense count: 234
+# Offense count: 220
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 45
 
@@ -263,7 +275,8 @@ Metrics/ParameterLists:
     - 'test/functional/source_controller_test.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 194
+# Offense count: 181
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 45
 
@@ -389,14 +402,14 @@ RSpec/DescribeClass:
     - 'spec/routing/webui/projects/ssl_certificate_spec.rb'
     - 'spec/routing/webui_matcher_spec.rb'
 
-# Offense count: 227
+# Offense count: 404
 # Cop supports --auto-correct.
 # Configuration parameters: SkipBlocks, EnforcedStyle.
 # SupportedStyles: described_class, explicit
 RSpec/DescribedClass:
   Enabled: false
 
-# Offense count: 88
+# Offense count: 120
 # Cop supports --auto-correct.
 RSpec/EmptyLineAfterFinalLet:
   Enabled: false
@@ -496,7 +509,7 @@ RSpec/IteratedExpectation:
   Exclude:
     - 'spec/models/user_spec.rb'
 
-# Offense count: 243
+# Offense count: 258
 # Cop supports --auto-correct.
 RSpec/LeadingSubject:
   Enabled: false
@@ -692,7 +705,20 @@ Rails/HelperInstanceVariable:
     - 'app/helpers/webui/projects/status_helper.rb'
     - 'app/helpers/webui/webui_helper.rb'
 
-# Offense count: 62
+# Offense count: 2
+# Cop supports --auto-correct.
+Rails/IndexBy:
+  Exclude:
+    - 'app/models/architecture.rb'
+    - 'app/models/role.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Rails/IndexWith:
+  Exclude:
+    - 'app/controllers/configurations_controller.rb'
+
+# Offense count: 66
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:
@@ -795,7 +821,7 @@ Style/Alias:
     - 'app/models/role.rb'
     - 'test/test_helper.rb'
 
-# Offense count: 122
+# Offense count: 130
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -901,7 +927,11 @@ Style/FormatStringToken:
     - 'app/helpers/webui/project_helper.rb'
     - 'lib/backend/connection_helper.rb'
 
-# Offense count: 1238
+# Offense count: 785
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 1309
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: when_needed, always, never
@@ -993,7 +1023,7 @@ Style/NumericLiterals:
   Exclude:
     - 'app/presenters/obs_factory/staging_project_presenter.rb'
 
-# Offense count: 43
+# Offense count: 39
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison
@@ -1119,8 +1149,9 @@ Style/UnneededCondition:
 Style/WordArray:
   Enabled: false
 
-# Offense count: 9030
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 9079
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
   Max: 187
-- 
2.31.1

Places

File obs-server-2.10-0113-Ignore-rubocop-offenses-in-existing-codebase-after-r.patch of Package obs-server (Revision 2264e8d04946bebb1f76fe9fcb3c20e1)

Places