File obs-server-2.7.1-0015-backend-Fix-cleanup-in-BS... of Package obs-server

Overview Repositories Revisions Requests Users Attributes Meta

File obs-server-2.7.1-0015-backend-Fix-cleanup-in-BSSched-EventSource-Directory.patch of Package obs-server (Revision a54184d12a5b83bb4ed61fe52fa6ec1e)

Currently displaying revision a54184d12a5b83bb4ed61fe52fa6ec1e , Show latest

From 9f0efbd5f67dc822ebc42901989d63a87aa2f6e2 Mon Sep 17 00:00:00 2001
From: Oleg Girko <ol@infoserver.lv>
Date: Wed, 29 Jun 2016 20:00:40 +0100
Subject: [PATCH 15/29] [backend] Fix cleanup in
 BSSched::EventSource::Directory test.

The $! (errno) variable is not assigned to zero upon successful
system call.

This means that value of $! should not be used to check whether
rmdir() or unlink() succeeded; return value should be checked instead.

Signed-off-by: Oleg Girko <ol@infoserver.lv>
---
 src/backend/t/0015-BSSched-EventSource-Directory.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/t/0015-BSSched-EventSource-Directory.t b/src/backend/t/0015-BSSched-EventSource-Directory.t
index d08b851..946be5e 100644
--- a/src/backend/t/0015-BSSched-EventSource-Directory.t
+++ b/src/backend/t/0015-BSSched-EventSource-Directory.t
@@ -257,7 +257,7 @@ push(@files_to_remove,"$ev_dir/$file_name");
 # CLEANUP
 unshift(@files_to_remove,"$eventdir_base/$arch/$evname");
 
-map { ( -d $_ ) ? rmdir $_ : unlink $_ ; die "$_: $!" if $!;} @files_to_remove;
+map { ( -d $_ ) ? rmdir $_ : unlink $_ or die "$_: $!";} @files_to_remove;
 
 exit 0;
 
-- 
2.7.4

Places

File obs-server-2.7.1-0015-backend-Fix-cleanup-in-BSSched-EventSource-Directory.patch of Package obs-server (Revision a54184d12a5b83bb4ed61fe52fa6ec1e)

Places