File obs-server-2.8-0102-ci-Rails-5.1-Fix-test-failu... of Package obs-server

Overview Repositories Revisions Requests Users Attributes Meta

File obs-server-2.8-0102-ci-Rails-5.1-Fix-test-failure-caused-by-url_for-chan.patch of Package obs-server (Revision 617c434d5a327d4f9d9c86ae16dc58d1)

Currently displaying revision 617c434d5a327d4f9d9c86ae16dc58d1 , Show latest

From 3af6fef53cfa50095f23ab4e90e99cb3d48ca50a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Geuken?= <bgeuken@suse.de>
Date: Fri, 16 Jun 2017 14:21:05 +0200
Subject: [PATCH] [ci] Rails 5.1: Fix test failure caused by url_for changes

===

1) Webui::WebuiHelper#user_and_role for logged in users falls back to users login if realname is empty
     Failure/Error:
       image_tag(url_for(controller: '/webui/user', action: :user_icon, icon: user.login, size: size),
                 width: size, height: size, alt: alt, class: css_class)

ArgumentError:
       arguments passed to url_for can't be handled. Please require routes or provide your own implementation
     # ./app/helpers/webui/webui_helper.rb:39:in `user_icon'
     # ./app/helpers/webui/webui_helper.rb:253:in `user_and_role'
     # ./spec/helpers/webui/webui_helper_spec.rb:337:in `block (4 levels) in <top (required)>'
     # ./spec/support/logging.rb:4:in `block (2 levels) in <top (required)>'
---
 src/api/app/helpers/webui/webui_helper.rb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/api/app/helpers/webui/webui_helper.rb b/src/api/app/helpers/webui/webui_helper.rb
index c13d7d34a..00e0937df 100644
--- a/src/api/app/helpers/webui/webui_helper.rb
+++ b/src/api/app/helpers/webui/webui_helper.rb
@@ -36,8 +36,7 @@ module Webui::WebuiHelper
     user = User.find_by_login!(user) unless user.is_a? User
     alt ||= user.realname
     alt = user.login if alt.empty?
-    image_tag(url_for(controller: :user, action: :user_icon, icon: user.login, size: size),
-              width: size, height: size, alt: alt, class: css_class)
+    image_tag(user_icon_path(icon: user.login, size: size), width: size, height: size, alt: alt, class: css_class)
   end
 
   def fuzzy_time(time, with_fulltime = true)
-- 
2.14.3

Places

File obs-server-2.8-0102-ci-Rails-5.1-Fix-test-failure-caused-by-url_for-chan.patch of Package obs-server (Revision 617c434d5a327d4f9d9c86ae16dc58d1)

Places